Skip to content

merge yield statement for draining#116

Closed
cometkim wants to merge 2 commits into
mainfrom
merge-yield
Closed

merge yield statement for draining#116
cometkim wants to merge 2 commits into
mainfrom
merge-yield

Conversation

@cometkim
Copy link
Copy Markdown
Owner

@cometkim cometkim commented Dec 28, 2025

No description provided.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Dec 28, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 572f713

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Dec 28, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #116 will not alter performance

Comparing merge-yield (572f713) with main (5b3c150)

Summary

✅ 6 untouched

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 28, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (5b3c150) to head (572f713).

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #116   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          907       896   -11     
=========================================
- Hits           907       896   -11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cometkim
cometkim commented Dec 28, 2025
View reviewed changes
Comment thread src/grapheme.js
// else GB999: ÷ Any

if (boundary) {
if (boundary || cursor === len) {
Copy link
Copy Markdown
Owner Author

@cometkim cometkim Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly unnecessary check in the main loop.
Will definitely affect the perf.

@cometkim cometkim closed this Dec 28, 2025
@cometkim cometkim deleted the merge-yield branch December 28, 2025 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cometkim